Conversation
login, logout, and context use rewrite the whole file from the struct, so keys this CLI version does not know about (experimental on older builds, or anything added later) get dropped. Remember those keys on load and write them back on save. Fixes docker#5559 Signed-off-by: Dean Chen <862469039@qq.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
login / logout /
context userewriteconfig.jsonfrom the struct, so any key this CLI version does not know about gets dropped.experimentalis the one that bit me on an older build; same thing will happen for fields added later.Keep those keys around on load and write them back on save. Known fields still win if both are present.
Fixes #5559