test: refresh diagnostic API snapshots - #412
Merged
Merged
Conversation
|
@dvcolomban is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Sep 28, 2026
antfu
approved these changes
Sep 29, 2026
antfu
marked this pull request as ready for review
September 29, 2026 00:42
◈ PR LensNote The title starts with
|
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
antfu
enabled auto-merge
September 29, 2026 00:42
antfu
disabled auto-merge
September 29, 2026 00:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background (Why)
The API snapshot job fails on unchanged main at
9aa752a1. Its generated diagnostic declarations include an explicitnevergeneric and expanded location types from the lockednosticsdependency. The checked-in snapshots do not match those declarations. See the failing unit jobs in base CI.Changes (What)
Refresh only the diagnostic declarations in the
devframe/internal,@devframes/plugin-code-server/nodeand@devframes/plugin-terminals/nodesnapshots. No source code, dependencies or runtime behavior changes.This repair is separate from #410 and #411 so their feature diffs do not contain unrelated baseline updates.
Verification (Testing)
Generated from fresh package artifacts with the existing lockfile. The focused API snapshot comparison passes for these exports. The unchanged main implementation also passes the devframe build and browser-import guard. CI runs the full unit matrix and remaining repository gates.
Five of the six unit-matrix jobs now pass. The Linux Node 24 job reports a different snapshot mismatch in
@devframes/plugin-inspect, where generated declarations differ between declarations and re-exports. That snapshot and its implementation are untouched here, and the other five jobs pass with the same checked-in snapshot. A maintainer rerun is needed to investigate that remaining job; this branch author cannot rerun upstream workflows. CI run.