fix: unused printf tokens no longer consume the +ms suffix - #1059
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
When colors are enabled, formatArgs pushed the duration as a trailing argument. util.format then substituted that value into any unused %s/%d in the message (issue debug-js#967). Append the colored +ms suffix to the format string instead, matching how the non-color path embeds the timestamp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #967.
When colors are enabled,
formatArgspushed the+msduration as a trailing argument.util.formatWithOptionsthen substituted that value into any unused%s/%din the message (e.g.debug('hello %s')printedhello +0ms).Fix
Append the colored
+mssuffix to the format string instead of pushing a separate argument, consistent with how the non-color path embeds the timestamp.Test plan
DEBUG_COLORS=yesunused%skeeps literal%sand still shows+Nms; supplied args still format correctly