docs(helm): sync values table and badges with the chart - #8024
Merged
Merged
Conversation
docs/helm.md was moved from the chart README in 2021 and never regenerated. Four defaults were stale (image.tag, persistence.size, service.port, serviceAccount.name), eight used keys in values.yaml were missing, the version badges showed chart 1.0.0 / app 4.8.0, and the values.yaml link resolved to docs/values.yaml, which does not exist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
code-asher
approved these changes
Sep 29, 2026
code-asher
left a comment
code-asher
left a comment
Member
There was a problem hiding this comment.
Thank you! I need to add a ci check for this or something so it stops getting out of date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue: minor docs fix.
docs/helm.mdwas moved here from the chart README in #4035/#4044 and has not been regenerated since, so the values table and badges no longer matchci/helm-chart.Stale defaults (truth in
ci/helm-chart/values.yaml):image.tag:"4.8.0"->"4.139.1"(values.yaml:9)persistence.size:"1Gi"->"10Gi"service.port:8443->8080(values.yaml:50)serviceAccount.name:nil->""(values.yaml:32)Badges: chart
1.0.0->3.54.0, app4.8.0->4.139.1(Chart.yaml:18,23).Missing keys added:
annotations,extraPorts,ingress.ingressClassName,lifecycle.enabled,livenessProbe.enabled,priorityClassName,readinessProbe.enabled,serviceAccount.annotations. I left outlabels: it is in values.yaml, but no template reads.Values.labels, so documenting it would suggest a setting that does nothing.Link: the "default values.yaml" tip linked
values.yaml, which resolves todocs/values.yamland is a 404 on https://coder.com/docs/code-server/latest/helm. It now links../ci/helm-chart/values.yaml, the same relative style the other docs pages use.Checked by comparing every leaf key and default in values.yaml against the table with a script, and
prettier --check docs/helm.mdpasses.Prepared with AI assistance (Claude Code) and reviewed with GitHub Copilot.
🤖 Generated with Claude Code