Fix update tester offering an already-installed version - #1290
Merged
Merged
Conversation
The tester forced Cloudinary into the update list without checking the installed version, and self-deactivated via a hard-coded folder name that often did not match, so it could keep re-injecting the update forever. Compare against the installed version, drop a previously injected update once it is installed, use plugin_basename() for deactivation, and give the tester zip a top-level folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update tester (
package/package.php) forced Cloudinary into the update list without checking the installed version, so with the test build already installed it kept showing"There is a new version of Cloudinary available"for that same version. Its self-deactivation also relied on a hard-coded folder name that often didn't match, leaving it active and re-injecting the update on every check.This compares against the installed version (and drops a previously injected update once it's installed), deactivates via
plugin_basename(), and gives the tester zip a top-level folder.