Skip to content

Migrate github.com/SermoDigital to github.com/golang-jwt for 1.27.0 c… - #3872

Open
benjaminguttmann-avtq wants to merge 1 commit into
cloudfoundry:v8from
benjaminguttmann-avtq:switch-sermodigital-jose-to-golang-jwt-v8
Open

benjaminguttmann-avtq wants to merge 1 commit into
cloudfoundry:v8from
benjaminguttmann-avtq:switch-sermodigital-jose-to-golang-jwt-v8

Conversation

@benjaminguttmann-avtq

Copy link
Copy Markdown
Contributor

…ompat

Thank you for contributing to the CF CLI! Please read the following:

Note: Please create separate PR for every branch (main and v8) as needed.

Description of the Change

This PR switches from using github.com/SermoDigital to use github.com/golang-jwt as there are issues with SermoDigital and golang 1.27.0 (https://github.com/cloudfoundry/cf_exporter/actions/runs/32944433448/job/98102027604).

goroutine 1 [running]:
crypto.RegisterHash(...)
	/opt/hostedtoolcache/go/1.27.0/x64/src/crypto/crypto.go:158
github.com/SermoDigital/jose/crypto.init.0()
	/home/runner/work/cf_exporter/cf_exporter/vendor/github.com/SermoDigital/jose/crypto/none.go:11 +0x25
FAIL	github.com/cloudfoundry/cf_exporter/v2/fetcher	0.008s
=== RUN   TestFilters
Running Suite: Filters Suite

v8 version of PR #3852

Note: PR has been created with the usage of AI

Why Is This PR Valuable?

Makes it possible to bump golang to v1.27.0.

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

Who else is affected by the change?
ry/cli/blob/main/.github/CONTRIBUTING.md)

  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Note: Please create separate PR for every branch (main and v8) as needed.

Description of the Change

We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.

Why Is This PR Valuable?

What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

Who else is affected by the change?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant