fix(ui): clear the invitation ticket when a sign-in completes on a challenge - #9621
zourzouvillys wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 5b5ad1b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e2305f1 to
b866d87
Compare
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
b866d87 to
31e46ed
Compare
31e46ed to
17bed3d
Compare
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 WalkthroughWalkthroughWhen a Protect Check sign-in completes with a created session, Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to Challenge-completed invitation sign-ins clear the ticket from the URL, matching the existing sign-in flow. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Comment |
17bed3d to
74c0386
Compare
…allenge A ticket sign-in that would have completed on the start page completes on the challenge instead, which did not clear the ticket from the URL. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
74c0386 to
5b5ad1b
Compare
Description
Stacked on #9620 — review the delta only; that one merges first.
A sign-in started from an organization invitation clears the ticket from the URL when it completes. If a verification challenge is required, the sign-in completes on the challenge instead, which did not clear it — so the ticket stayed in the address bar afterwards.
Clear it there too, matching what the start page and the sign-up flow already do.
Effects and risks
removeClerkQueryParamis a no-op when the parameter is absent, so this only affects the ticket case.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change