Skip to content

fix(deps): patch fast-uri to 3.1.7 - #992

Merged
tobyhede merged 1 commit into
mainfrom
fix/cip-4271-fast-uri-patch
Oct 1, 2026
Merged

tobyhede merged 1 commit into
mainfrom
fix/cip-4271-fast-uri-patch

Conversation

@tobyhede

Copy link
Copy Markdown
Contributor

Raises the existing fast-uri override in pnpm-workspace.yaml from <3.1.6 → 3.1.6 to <3.1.7 → 3.1.7 to fix GHSA-58mr-gqgx-xq4g (CVE-2026-84394, Dependabot alert #215).

  • fast-uri is only reached transitively through ajv. After the change, pnpm why -r fast-uri resolves a single version: 3.1.7.
  • 3.1.7 was published 2026-09-02, which is outside the 7-day minimumReleaseAge window.
  • pnpm install --frozen-lockfile passes.

pnpm also rewrote the @types/node peer suffix on vitest in the @vitest/coverage-v8@4.1.11 snapshot, from 26.2.0 to 22.20.1. That matches the root @types/node pin, so it appears to correct drift already on main.

@tobyhede
tobyhede requested a review from a team as a code owner September 30, 2026 23:29
@changeset-bot

changeset-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 263f8e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T23:32:21.991022Z 263f8e2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@freshtonic freshtonic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is correct. I approve it.

What I checked:

  • The override moves from fast-uri@<3.1.6 → 3.1.6 to fast-uri@<3.1.7 → 3.1.7. The selector stays range-scoped, and its upper bound is the same as the target. Thus the shape test and the "every security override took effect" test in e2e/tests/supply-chain.e2e.test.ts stay valid. The E2E job passed.
  • In the lockfile, fast-uri has only one version (3.1.7), and ajv@8.20.0 resolves to it. No 3.1.6 entry remains.
  • The new comment follows the existing pattern: alert number, CVE, GHSA, and publish date. It keeps the #198 history above it.
  • A changeset is not necessary. Workspace overrides do not go into a published tarball, so this change does not change the surface of a package. No skill names a fast-uri version.
  • All required checks pass, which includes osv-scanner and the frozen-lockfile install.

One note, which does not block the merge: the @types/node peer suffix change on the @vitest/coverage-v8@4.1.11 snapshot is not completely a drift fix. The lockfile at this head still has two vitest variants, vitest@4.1.11(@types/node@22.20.1)… and vitest@4.1.11(@types/node@26.2.0)…. Most importers still use the 26.2.0 variant (for example, lockfile lines 118, 280 and 342). The coverage-v8 snapshot has only one entry, so pnpm selects one of the two variants for its back-reference, and the selection can change on each re-resolve. The change has no effect at runtime, but it can occur again in unrelated lockfile diffs. If you want to stop this, align the @types/node 26.x consumers to the root pin in a different PR.

@tobyhede
tobyhede merged commit 349a78e into main Oct 1, 2026
29 checks passed
@tobyhede
tobyhede deleted the fix/cip-4271-fast-uri-patch branch October 1, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants