fix(deps): patch fast-uri to 3.1.7 - #992
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
freshtonic
left a comment
There was a problem hiding this comment.
The change is correct. I approve it.
What I checked:
- The override moves from
fast-uri@<3.1.6 → 3.1.6tofast-uri@<3.1.7 → 3.1.7. The selector stays range-scoped, and its upper bound is the same as the target. Thus the shape test and the "every security override took effect" test ine2e/tests/supply-chain.e2e.test.tsstay valid. The E2E job passed. - In the lockfile,
fast-urihas only one version (3.1.7), andajv@8.20.0resolves to it. No 3.1.6 entry remains. - The new comment follows the existing pattern: alert number, CVE, GHSA, and publish date. It keeps the #198 history above it.
- A changeset is not necessary. Workspace overrides do not go into a published tarball, so this change does not change the surface of a package. No skill names a
fast-uriversion. - All required checks pass, which includes
osv-scannerand the frozen-lockfile install.
One note, which does not block the merge: the @types/node peer suffix change on the @vitest/coverage-v8@4.1.11 snapshot is not completely a drift fix. The lockfile at this head still has two vitest variants, vitest@4.1.11(@types/node@22.20.1)… and vitest@4.1.11(@types/node@26.2.0)…. Most importers still use the 26.2.0 variant (for example, lockfile lines 118, 280 and 342). The coverage-v8 snapshot has only one entry, so pnpm selects one of the two variants for its back-reference, and the selection can change on each re-resolve. The change has no effect at runtime, but it can occur again in unrelated lockfile diffs. If you want to stop this, align the @types/node 26.x consumers to the root pin in a different PR.
Raises the existing
fast-urioverride inpnpm-workspace.yamlfrom<3.1.6 → 3.1.6to<3.1.7 → 3.1.7to fix GHSA-58mr-gqgx-xq4g (CVE-2026-84394, Dependabot alert #215).pnpm why -r fast-uriresolves a single version: 3.1.7.minimumReleaseAgewindow.pnpm install --frozen-lockfilepasses.pnpm also rewrote the
@types/nodepeer suffix on vitest in the@vitest/coverage-v8@4.1.11snapshot, from 26.2.0 to 22.20.1. That matches the root@types/nodepin, so it appears to correct drift already on main.