Conversation
dlowzzxx
requested review from
SrinivasanTarget,
mykola-mokhnach,
saikrishna321 and
valfirst
as code owners
September 25, 2026 15:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Fixes #2372. An
@OverrideWidgetfield declared as an abstractWidgetsubclass now dispatches its abstract methods to the selected Android, iOS, or HTML widget instead of throwingAbstractMethodError. The enhanced proxy intercepts those methods; when no listener handles one, it retains the original error behavior.Types of changes
Details and validation
masterwith the reportedAbstractMethodError; the patched test passes for Android, iOS, desktop browser, and Android webview, with both single-widget and widget-list fields. A separate test confirms an unhandled abstract method still throws.gradlew test assemble checkstyleMain checkstyleTest --continueran 96 tests: 95 passed.StorageTestcould not connect to the absent local Appium server at127.0.0.1:4723; the clean base fails there too. Assembly and main-code Checkstyle passed. Test-code Checkstyle found the same five Javadoc errors in untouched files on the clean base and patch.git diff --checkpassed.AppiumDriver/AppiumCommandExecutorcode; the same snapshot errors appeared on merged PR build: include LICENSE and NOTICE in published JARs #2450. The full check matrix is therefore not green. No physical device validation was performed.This change was AI-assisted with Codex. The validation and limits are described above; no maintainer review has occurred. If eligible after merge, I would welcome consideration under Appium's discretionary contributor compensation scheme, with any payout details handled privately through Open Collective.