Skip to content

chore(deps): Drop opentelemetry-instrumentation-httpx from the otel extra - #2213

Merged
vdusek merged 5 commits into
masterfrom
fix/httpx2-otel-instrumentation-floor
Sep 24, 2026
Merged

vdusek merged 5 commits into
masterfrom
fix/httpx2-otel-instrumentation-floor

Conversation

@vdusek

@vdusek vdusek commented Sep 7, 2026 •

Copy link
Copy Markdown
Collaborator

Removes opentelemetry-instrumentation-httpx from the otel extra. Crawlee never imports it, and it only mattered when HttpxHttpClient was the default client. It also didn't work anymore: HttpxHttpClient runs on httpx2, and HTTPXClientInstrumentor records no spans for it.

The other OpenTelemetry floors go back to their master values. The bump to the 0.65b0 / 1.44.0 line was only needed because opentelemetry-instrumentation-httpx==0.65b0 pins its siblings with ==.

The tracing guide now says how to trace HttpxHttpClient requests: install opentelemetry-instrumentation-httpx>=0.65b0 yourself and use HTTPX2ClientInstrumentor.

✍️ Drafted by Claude Code

@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Sep 7, 2026
@vdusek vdusek self-assigned this Sep 7, 2026
@github-actions github-actions Bot added this to the 149th sprint - Tooling team milestone Sep 7, 2026
@codecov

codecov Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.73%. Comparing base (dd5c5e6) to head (3346b12).
⚠️ Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2213      +/-   ##
==========================================
- Coverage   93.74%   93.73%   -0.01%     
==========================================
  Files         181      181              
  Lines       12865    12884      +19     
==========================================
+ Hits        12060    12077      +17     
- Misses        805      807       +2     
Flag Coverage Δ
unit 93.73% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek changed the title fix: Require opentelemetry-instrumentation-httpx 0.65b0 for httpx2 instrumentation fix: Require opentelemetry-instrumentation-httpx 0.65b0 and correct the web form example Sep 7, 2026
@vdusek
vdusek marked this pull request as ready for review September 16, 2026 08:45
@vdusek vdusek changed the title fix: Require opentelemetry-instrumentation-httpx 0.65b0 and correct the web form example fix: OpenTelemetry httpx2 instrumentation and the web form example Sep 16, 2026
@vdusek
vdusek force-pushed the fix/httpx2-otel-instrumentation-floor branch from 8dcdd20 to 18a51db Compare September 16, 2026 09:04
@vdusek vdusek changed the title fix: OpenTelemetry httpx2 instrumentation and the web form example fix: Instrument httpx2 requests in the otel extra Sep 16, 2026
@vdusek
vdusek requested a review from Pijukatel September 16, 2026 09:07
@Mantisus

Copy link
Copy Markdown
Collaborator

If I'm not mistaken, opentelemetry-instrumentation-httpx was added as a dependency when HttpxHttpClient was the default client. Maybe we can remove that?

Comment thread pyproject.toml Outdated
@vdusek

vdusek commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator Author

If I'm not mistaken, opentelemetry-instrumentation-httpx was added as a dependency when HttpxHttpClient was the default client. Maybe we can remove that?

cc @Pijukatel

@Pijukatel

Copy link
Copy Markdown
Collaborator

If I'm not mistaken, opentelemetry-instrumentation-httpx was added as a dependency when HttpxHttpClient was the default client. Maybe we can remove that?

cc @Pijukatel

I guess we can. It would be useful only if someone uses httpx and otel extras, and if desired, one can add it on their own.

@Pijukatel

This comment was marked as duplicate.

@vdusek vdusek changed the title fix: Instrument httpx2 requests in the otel extra chore(deps): Drop opentelemetry-instrumentation-httpx from the otel extra Sep 24, 2026
@vdusek
vdusek merged commit 45bb0e2 into master Sep 24, 2026
35 of 37 checks passed
@vdusek
vdusek deleted the fix/httpx2-otel-instrumentation-floor branch September 24, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants