Fix HttpClient 5.x callback span handling - #832
Open
Ayush0612005 wants to merge 1 commit into
Open
Ayush0612005 wants to merge 1 commit into
Ayush0612005 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix HttpClient 5.x plugin closing the caller thread's active span (#14097)
The HttpClient 5.x plugin's
FutureCallbackWrapperpreviously stopped thecurrently active span without checking whether that span belonged to the
HttpClient request.
When the
FutureCallbackexecutes on the caller/business thread, this canincorrectly stop the caller's active span.
The fix tracks the request-owned local span in the
HttpContextand onlystops it when it is the active span on the current thread. The local span is
also explicitly finished on the I/O thread after the response is consumed.
Regression tests cover callbacks executing on both I/O and caller/business
threads.
CHANGESlog.