HTTP/2: Correct pushed response message handling - #714
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
Handle informational responses and trailers in pushed responses. Validate END_STREAM and Content-Length at message completion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP/2: Correct pushed response message handling
RFC 9113 requires pushed responses to use the same response sequence as regular HTTP/2 responses.
Handle informational responses before the final pushed response and allow trailer HEADERS after the response body.
Reject informational responses carrying
END_STREAMand trailers withoutEND_STREAM. ValidateContent-Lengthwhen a pushed response terminates with trailers.RFC 9113:
https://www.rfc-editor.org/rfc/rfc9113.html#section-8.1
https://www.rfc-editor.org/rfc/rfc9113.html#section-8.1.1
https://www.rfc-editor.org/rfc/rfc9113.html#section-8.4.2