Reject H2 DATA on reserved streams - #709
Merged
arturobernalg merged 1 commit intoSep 30, 2026
Merged
Conversation
Report a connection PROTOCOL_ERROR when DATA is received on a reserved stream.
ok2c
reviewed
Sep 29, 2026
ok2c
left a comment
ok2c
left a comment
Member
There was a problem hiding this comment.
@arturobernalg Please cherry-pick to 5.4.x
Member
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9113 Section 5.1 restricts the frame types that can be received while a stream is in a reserved state.
For a
reserved (remote)stream, receiving a frame other thanHEADERS,RST_STREAM, orPRIORITYmust be treated as a connection error of typePROTOCOL_ERROR.DATAis therefore not permitted before the reserved stream has been activated byHEADERS.The current DATA path accepts a reserved stream and passes the payload to the stream handler.
This change rejects DATA frames received on reserved streams with a connection
PROTOCOL_ERRORand adds a regression test covering DATA received on areserved (remote)stream created byPUSH_PROMISE.RFC 9113 Section 5.1 — Stream States,
reserved (remote):https://www.rfc-editor.org/rfc/rfc9113.html#section-5.1