Optimize message list traversal - #707
Merged
arturobernalg merged 1 commit intoSep 30, 2026
Merged
arturobernalg merged 1 commit into
arturobernalg merged 1 commit into
Conversation
Use indexed access for random-access lists. Use sequential iteration for other list implementations.
ok2c
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MessageSupportacceptsListinstances but currently uses the same traversal strategy regardless of the underlying list implementation.This change uses indexed access for
RandomAccesslists and sequential iteration otherwise, avoiding repeated traversal for lists such asLinkedListwhile preserving the existing fast path forArrayList.JMH results:
formatTokensArrayListformatTokensLinkedListformatElementsArrayListformatElementsLinkedListThe change is limited to list traversal in
formatTokens,formatElements, andformatParameters.