Skip to content

ci: Add target release version labels to merged PRs - #25776

Merged
alamb merged 6 commits into
apache:mainfrom
nuno-faria:pr_release_label
Sep 28, 2026
Merged

alamb merged 6 commits into
apache:mainfrom
nuno-faria:pr_release_label

Conversation

@nuno-faria

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Adds a release version label to merged PRs so it's easy to determine which version a PR will land/has landed.

What changes are included in this PR?

  • New workflow.
  • Updated the dev/update_datafusion_versions.py script to automatically update the version in the workflow.

What is the testing strategy for this PR?

This PR.

Are there any user-facing changes?

No.

@github-actions github-actions Bot added the development-process Related to development process of DataFusion label Sep 26, 2026
@codecov-commenter

codecov-commenter commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.51%. Comparing base (6a792c6) to head (2f2359d).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25776      +/-   ##
==========================================
+ Coverage   82.49%   82.51%   +0.01%     
==========================================
  Files        1140     1141       +1     
  Lines      438555   439780    +1225     
  Branches   438555   439780    +1225     
==========================================
+ Hits       361803   362884    +1081     
- Misses      54880    54953      +73     
- Partials    21872    21943      +71     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nuno-faria

Copy link
Copy Markdown
Contributor Author

I'm not sure if its possible to test this without merging to main, as it requires additional permissions to create the label:

https://github.com/apache/datafusion/actions/runs/36247423656/job/108419093281

POST /repos/apache/datafusion/labels - 403 with id 2040:283A1E:2A73CD0:8D1DC93:6AB7D19E in 127ms
RequestError [HttpError]: Resource not accessible by integration - https://docs.github.com/rest/issues/labels#create-a-label
    at fetchWrapper (/home/runner/work/_actions/actions/github-script/v9.0.0/dist/index.js:61509:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:104:5)
    at async eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v9.0.0/dist/index.js:64949:16), <anonymous>:14:5)
    at async main (/home/runner/work/_actions/actions/github-script/v9.0.0/dist/index.js:65100:20) {

@nuno-faria
nuno-faria marked this pull request as ready for review September 26, 2026 15:47
@nuno-faria
nuno-faria requested a review from alamb September 26, 2026 15:47

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try -- thanks @nuno-faria

uses: actions/github-script@v9.0.0
with:
script: |
const target_version = 'v56.0.0';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could drive this from a data file rather than an inline script (maybe we could even start updating the version on main before we cut a new release 🤔 )

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb, I moved the script to a file.
This is already intended to start now, target_version is set to 56 since new PRs will target the next version, so they get the label "v56" (sorry if I misunderstood your question).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great -- thank you -- let's try it

@alamb
alamb added this pull request to the merge queue Sep 28, 2026
@alamb

alamb commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Thanks @nuno-faria -- I'll merge this in and we can give it a try.

If people find it useful, we can always send an agent / script to update existing PRs with backdated release information

Merged via the queue into apache:main with commit 51c2e04 Sep 28, 2026
41 checks passed
@nuno-faria
nuno-faria deleted the pr_release_label branch September 28, 2026 18:23
@nuno-faria

Copy link
Copy Markdown
Contributor Author

When moving the script to a dedicated file I forgot to checkout the code, so it is currently failing: https://github.com/apache/datafusion/actions/runs/36464821849. I'll try to fix it.

@nuno-faria

Copy link
Copy Markdown
Contributor Author

Hopefully fixed by #25845.

limadog9 pushed a commit to limadog9/datafusion that referenced this pull request Sep 28, 2026
…he#25845)

## Which issue does this PR close?

- N/A.

## Rationale for this change

Follow up to apache#25776. Adds the
missing checkout to the release version workflow.

## What changes are included in this PR?

- Added the missing checkout.
- Fix the script fmt.

## What is the testing strategy for this PR?

N/A.

## Are there any user-facing changes?

No.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Track PR release version with labels/milestones

3 participants