ci: Add target release version labels to merged PRs - #25776
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25776 +/- ##
==========================================
+ Coverage 82.49% 82.51% +0.01%
==========================================
Files 1140 1141 +1
Lines 438555 439780 +1225
Branches 438555 439780 +1225
==========================================
+ Hits 361803 362884 +1081
- Misses 54880 54953 +73
- Partials 21872 21943 +71 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I'm not sure if its possible to test this without merging to main, as it requires additional permissions to create the label: https://github.com/apache/datafusion/actions/runs/36247423656/job/108419093281 |
alamb
left a comment
There was a problem hiding this comment.
Let's give it a try -- thanks @nuno-faria
| uses: actions/github-script@v9.0.0 | ||
| with: | ||
| script: | | ||
| const target_version = 'v56.0.0'; |
There was a problem hiding this comment.
maybe we could drive this from a data file rather than an inline script (maybe we could even start updating the version on main before we cut a new release 🤔 )
There was a problem hiding this comment.
Thanks @alamb, I moved the script to a file.
This is already intended to start now, target_version is set to 56 since new PRs will target the next version, so they get the label "v56" (sorry if I misunderstood your question).
There was a problem hiding this comment.
Sounds great -- thank you -- let's try it
|
Thanks @nuno-faria -- I'll merge this in and we can give it a try. If people find it useful, we can always send an agent / script to update existing PRs with backdated release information |
|
When moving the script to a dedicated file I forgot to checkout the code, so it is currently failing: https://github.com/apache/datafusion/actions/runs/36464821849. I'll try to fix it. |
|
Hopefully fixed by #25845. |
…he#25845) ## Which issue does this PR close? - N/A. ## Rationale for this change Follow up to apache#25776. Adds the missing checkout to the release version workflow. ## What changes are included in this PR? - Added the missing checkout. - Fix the script fmt. ## What is the testing strategy for this PR? N/A. ## Are there any user-facing changes? No.
Which issue does this PR close?
Rationale for this change
Adds a release version label to merged PRs so it's easy to determine which version a PR will land/has landed.
What changes are included in this PR?
dev/update_datafusion_versions.pyscript to automatically update the version in the workflow.What is the testing strategy for this PR?
This PR.
Are there any user-facing changes?
No.