Spans: (some of the) ALTER statements - #2572
Closed
LucaCappelletti94 wants to merge 1 commit into
Closed
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
LucaCappelletti94
added this pull request to stack #2568
September 24, 2026 12:32
|
No dialect label was applied because the title does not name a SQL dialect. If this change targets one or more dialects, edit the title to Changed files touch PostgreSQL, Snowflake, SQL Server. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## span-create-statements #2572 +/- ##
==========================================================
- Coverage 85.11% 85.09% -0.03%
==========================================================
Files 43 43
Lines 34062 34123 +61
Branches 34062 34123 +61
==========================================================
+ Hits 28993 29038 +45
- Misses 1595 1596 +1
- Partials 3474 3489 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
span-alter-statements
branch
from
September 24, 2026 20:49
18fc5f9 to
b38942e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[THIS CHAIN OF PRS IS AT LEAST TEMPORARELY CLOSED BECAUSE SPANS ARE A VERY LARGE REFACTORING]
Twelve
ALTERstatements had an empty span, among themALTER FUNCTION,ALTER USER,ALTER ROLE,ALTER TYPEand the operator forms. They now store their first and last token, set inParser::parse_statementlike theDROPandCREATEstatements. The span baseline loses 402 lines and gains none.Part of #1548.