Handle fatal Errors in WebSocketClient read loop - #1510
Open
liyifan9642-creator wants to merge 5 commits into
Open
liyifan9642-creator wants to merge 5 commits into
liyifan9642-creator wants to merge 5 commits into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1460.
WebSocketImpl#decodeFramesrethrows fatal Errors (VirtualMachineError,ThreadDeath,LinkageError). The client read loop inWebSocketClient#runonly caughtIOExceptionandRuntimeException, so such a fatal Error escapedrun()and silently terminated the connect/read thread: noonError, noonClose, and no cleanup, leaving the socket half-open. The server-sideWebSocketWorkeralready handles this (see #1223); this change brings the client to parity.Changes
onError(wrapped, as elsewhere) and close the connection withCloseFrame.UNEXPECTED_CONDITION(1011).Issue1460Test, which uses a customDraftthat throws aLinkageErrorduringtranslateFrame. The test fails before the change (no callbacks, thread dies) and passes after.Notes
VirtualMachineErrorto be rethrown after cleanup instead.