add algorithm to check if given string is valid number or not - #11479
Conversation
|
Need to migrate to Below is the error raised by ruff check |
Add a new file string_is_valid_number.py in string directory
…ct state machine outside function
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
Please rebase this pull request on the current master branch. |
…ct state machine outside function
for more information, see https://pre-commit.ci
…ct state machine outside function
for more information, see https://pre-commit.ci
06b5006 to
272b0ca
Compare
|
Reviewed in the oldest-PR triage sweep. Nice work — a DFA-based validator is a genuinely instructive addition, and it's close to merge-ready.
Two small nits before merge:
Content-wise I'm happy with it. Thanks! |
67a0fae to
e3f077c
Compare
Add a new file string_is_valid_number.py in string directory
Describe your change:
Checklist: