Skip to content

ci: update to Nx v23 - #11567

Open
lachlancollins wants to merge 2 commits into
mainfrom
nx-v23
Open

lachlancollins wants to merge 2 commits into
mainfrom
nx-v23

Conversation

@lachlancollins

@lachlancollins lachlancollins commented Sep 21, 2026

Copy link
Copy Markdown
Member

🎯 Changes

See the release blog: https://nx.dev/blog/nx-23-release

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Privacy

    • Disabled Nx analytics and telemetry collection for the workspace.
  • Chores

    • Updated project tooling configuration.
    • Added additional generated Nx files and directories to version-control ignore rules.

@lachlancollins
lachlancollins requested a review from a team as a code owner September 21, 2026 11:02
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 22f25049-8a19-4225-9f7b-03c6689c85f0

📥 Commits

Reviewing files that changed from the base of the PR and between 21c4358 and 8f27f50.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 614e35cb-e3c9-45a6-8453-60bc5f4b01ec

📥 Commits

Reviewing files that changed from the base of the PR and between 413ba6e and 21c4358.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • .gitignore
  • nx.json
  • package.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The PR upgrades Nx from 22.1.3 to 23.2.1, disables Nx analytics, and adds three Nx-generated paths to .gitignore.

Changes

Nx workspace maintenance

Layer / File(s) Summary
Nx upgrade and workspace settings
.gitignore, nx.json, package.json
The Nx development dependency updates to 23.2.1. Nx analytics are disabled. .nx/migrate-runs, .nx/polygraph, and .nx/self-healing are ignored.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: tkdodo

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: updating the CI tooling to Nx v23.
Description check ✅ Passed The description includes the required Changes, Checklist, and Release Impact sections. It confirms testing, contribution-guide compliance, and that the change is development-only. The Changes section …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Sep 21, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 8f27f50

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 7m 5s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 45s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-22 12:56:58 UTC

@socket-security

socket-security Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednx@​22.1.3 ⏵ 23.2.168 +11100 +1893100100

View full report

@socket-security

socket-security Bot commented Sep 21, 2026

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
High CVE: npm smol-toml: Denial of Service via malformed TOML documents

CVE: GHSA-7w5x-hrqm-74c2 smol-toml: Denial of Service via malformed TOML documents (HIGH)

Affected versions: < 1.7.1

Patched version: 1.7.1

From: pnpm-lock.yamlnpm/nx@23.2.1npm/smol-toml@1.6.1

ℹ Read more on: This package | This alert | What is a CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/smol-toml@1.6.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

1 package(s) bumped directly, 3 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/svelte-query-devtools 6.2.3 → 6.2.4 Changeset
@tanstack/svelte-query 6.2.3 → 6.2.4 Dependent
@tanstack/svelte-query-persist-client 6.2.3 → 6.2.4 Dependent
@tanstack/vue-query-devtools 6.2.3 → 6.2.4 Dependent

@pkg-pr-new

pkg-pr-new Bot commented Sep 21, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11567

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11567

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11567

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11567

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11567

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11567

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11567

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11567

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11567

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11567

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11567

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11567

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11567

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11567

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11567

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11567

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11567

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11567

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11567

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11567

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11567

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11567

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11567

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11567

commit: 8f27f50

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.87 KB (0%)
react minimal 8.85 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant