Conversation
… delete keeps its secrets
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Characters, and"\r\n"is one grapheme cluster equal to neither"\n"nor"\r", so the whole file read as one record.127.0.0.1:3306.ConnectionInfoViewpicked the section with its owntype != .sqlitecheck, written before DuckDB existed.SELECT * FROMtemplate wroteLIMIT 100on SQL Server, Oracle and Redis, and left out the selected schema.QueryEditorViewbuilt the SQL string itself instead of callingSQLBuilder.buildSelect, the builder the data browser uses.query-history.json.ConnectionCoordinator.addHistoryItemappended the item after saving it, whatever the store actually kept after its dedupe and 200-entry cap.Tests
All run on an iOS 27.1 simulator in the
TableProMobilescheme. The 17 covering suites ran 162 tests, all passing.RowPayloadTests: "parses CSV with CRLF line endings", "keeps a CRLF inside a quoted CSV field", "parses CSV with carriage return line endings" and "splits a CSV field that starts with a combining mark". All four fail without the fix: the first three withemptyPayload, the last with the wrong split.ConnectionInfoContentTests(new): "A DuckDB file connection gets the File section with its name and path" and "An in-memory DuckDB connection says In Memory instead of a path" fail without the fix, returning.server. The SQLite and server cases pass either way and guard against the fix overreaching. "Only SQLite and DuckDB are local file engines" covers the new predicate.QueryTemplateTests(new): the SQL Server, Oracle, MySQL, PostgreSQL and Redis cases all fail without the fix. "Every iOS engine on the shared non-SQL list gets no SELECT template" passes either way; it ties the template toSQLDDLFallbackPolicyso a new non-SQL engine on iOS cannot get aSELECTtemplate unnoticed.DeletedConnectionPurgeTests(new): "Deleting a connection forgets its query history and keeps the others'" and "A connection deleted on another device loses its history and secrets here" fail without the fix. "The purge removes the connection's saved tab, database, schema and query, and no other connection's" covers the purge itself on a test defaults suite. "A sync merge that deletes nothing leaves every history alone" and "The saved-state keys keep the names already stored on the device" pass either way and guard against purging too much or renaming stored keys.ConnectionCoordinatorHistoryTests(new): "Running the same query twice in a row lists it once, as the store keeps it" and "A query past the store's cap drops the oldest entry from the list too" fail without the fix. "A history file that cannot be read or written leaves the listed history in place" fails when the list is reloaded after a write that did not happen (the list went to[]). "The same query failing after it succeeded is listed twice" passes either way.Docs
The docs rewrite branch covers the user-facing text for these changes.