Conversation
…s their own conditions instead of equality checks
…dropping those edits
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This was referenced Sep 30, 2026
Open
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
column = valueequality checks, and is not empty showed only the empty rows.SurrealQueryBuilder.conditionhandled 16 operators and itsdefault:arm wrote an equality for every other one, and the driver took the flattened tuple filter API, so BETWEEN arrived as"10,20"with no second bound and the raw row arrived as a column named__RAW__.inorouton a SurrealDB row together with another field saved the other field and dropped thein/outedit without a word, clearing it from the change queue and undo.SurrealStatementGeneratorremovedin,outandidfrom everyUPDATE, and the driver relied on the PluginKit defaultgenerateRowWrites, which counts a row as written whenever any statement comes out.Tests
All in
TableProTests/Plugins/SurrealDBDriverTests.swift. Each one below fails without the fix (measured by putting the old code back and running the suites):SurrealQueryBuilderTests:isEmpty,isNotEmpty,regex,rawRow,rawConditionThatReads,rawConditionThatWrites,rawConditionWithKeywordRecordId,refusedRawConditionThrowsOnTheServer,betweenFromAppEncoding,betweenWithCommaInBound,betweenWithPrependScalarBeforeTheSeparator,betweenFromJoinedValue,betweenFromJoinedValueWithPrependScalar,betweenWithOneBound,everyFilterBarOperatorIsMapped,unknownOperatorRefused,refusedFilterThrowsOnTheServer.SurrealStatementGeneratorTests:edgeEndpointEditIsRefused(column:)forinandout, andimmutableId.eachWriteNamesItsRowandemptyUpdatepin the per-row write mapping and the host's ownership probe. All eleven SurrealDB suites pass: 84 of 84.Docs
The docs rewrite branch covers the user-facing text. This PR also updates the Filters and Limitations sections of
docs/databases/surrealdb.mdxto match the new behavior.CI fixes
The Package Tests job failed in
SyncRecordMapperTests.unknownWireValueFailsClosed: an unknown Safe Mode value decoded as Off instead of Confirm Writes. The sync mapper now uses the model'sSafeModeLevel(wireValue:isReadOnly:)decoder. Unknown values require confirmation, legacy read-only restrictions remain, and renaming a connection preserves its unknown wire value. Added regression tests for read-only restrictions and renames.Integrated main and fixed another inherited build error:
SurrealValue.text(_:)calledjsonText(length), but main had replaced that helper with a property. Restored the length-aware helper, keepingJSONTruncationfor grid display and full JSON for exports. Existing long-structure export and grid-display tests cover both paths.Resolved the SurrealDB statement-generator and test conflicts with main. The merge preserves this PR's refusal of edits to
id,in, andout, together with main's refusal of writes carrying values shortened for display. Both sets of regression tests remain covered.Follow-up validation on the final merged branch:
swift test --package-path Packages/TableProCore: PASS, all Swift Testing and XCTest runs passed.SurrealDBDriverTests.swiftsuites, and the host's TableFilter model where needed. It adapts imports for the separate test module; it does not run the app's Xcode test host.git diff --check: PASS.verify.sh plugins(AllPlugins): PASS on the merged fix(plugin-surrealdb): BETWEEN, REGEX and IS EMPTY filters become equality checks #3218 branch, including the common SurrealDB helper fix.