Skip to content

fix(ios): read an unrecognized Safe Mode level from iCloud as Confirm Writes, not Off #3214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 1 commit into from
Sep 30, 2026
Merged

fix(ios): read an unrecognized Safe Mode level from iCloud as Confirm Writes, not Off #3214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Literal backticks in cloudflared, cloud-sql-proxy, SSH config, remote command and dump tool install messages.
- Tunnel command preview showing port 0 or the wrong host when Port is blank or the connection uses a host list.
- SSH tab host-list warning naming replica set failover for Redis and Kafka, and implying Sentinel works through a tunnel.
- iPhone and iPad reading a Safe Mode level they do not recognize from iCloud as Off.

## [0.76.1] - 2026-09-29

Expand Down
14 changes: 2 additions & 12 deletions Packages/TableProCore/Sources/TableProSync/SyncRecordMapper.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,22 +187,12 @@ public enum SyncRecordMapper {
}

private static func storedSafeModeLevel(in fields: SyncRecordFields<ConnectionSyncField>) -> SafeModeLevel {
safeModeLevel(
fromWire: fields[.safeModeLevel] as? String,
SafeModeLevel(
wireValue: fields[.safeModeLevel] as? String,
isReadOnly: (fields[.isReadOnly] as? Int64 ?? 0) != 0
)
}

private static func safeModeLevel(fromWire raw: String?, isReadOnly: Bool) -> SafeModeLevel {
guard let raw else { return isReadOnly ? .readOnly : .off }
if let level = SafeModeLevel(rawValue: raw) { return level }
switch raw {
case "silent": return .off
case "alert", "alertFull", "safeMode", "safeModeFull": return .confirmWrites
default: return isReadOnly ? .readOnly : .off
}
}

// MARK: - Update Existing CKRecord (preserves macOS-only fields)

public static func updateRecord(_ record: CKRecord, with connection: DatabaseConnection) {
Expand Down
Loading