support for manage access dialog - #331
Open
SharonStrats wants to merge 3 commits into
Open
SharonStrats wants to merge 3 commits into
SharonStrats wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Resolve the critical test-typecheck issue and the two moderate API and WebID issues.
Review effort: Lite
Findings: 1
Open (3)
What changed in this PR
Adds access-control planning APIs and WebID detection to support a manage-access dialog.
Changes:
- Adds ACL discovery, grant, and public-read planning methods.
- Re-exports access-control APIs and types.
- Adds WebID detection and dependency updates.
| File | Summary / Findings |
|---|---|
src/types.ts |
Extends ACL and resource interfaces. Critical: Update typed test doubles or make additions optional to prevent typecheck-test failure. |
src/resource/resourceLogic.ts |
Adds WebID detection. Moderate: Accept supported profile-card URL variants such as /profile/card.ttl. |
src/index.ts |
Exposes access-control APIs. Moderate: Re-export ACLContext. |
src/acl/aclLogic.ts |
Wraps ACL discovery and planning helpers. |
package.json |
Adds the access-control dependency. |
package-lock.json |
Updates dependency resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SharonStrats
force-pushed
the
feat/access
branch
from
September 26, 2026 23:40
abd8524 to
f4e8c9c
Compare
Prompt: Add basic tests to cover the new acl logic functions that have been added Co-authored-by: GPT-5.4 Mini <gpt-5.4-mini@openai.com>
SharonStrats
force-pushed
the
feat/access
branch
from
September 27, 2026 00:55
f4e8c9c to
ebaaeb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Extended aclLogic to support the new manage access dialog by wiring in the necessary ACL helpers and access planning logic from @dokieli/web-access-control.
Alse added a function to resource logic to determine whether or not the resource is a webID.
Note: aclLogic will evolve as I complete the work, this is just to support the basic structure working.