Add full macOS compatibility - #2
Merged
Merged
Conversation
NicholaiVogel
force-pushed
the
hermes/hermes-7fefc18b
branch
from
September 17, 2026 11:35
1c379c8 to
57d2e9f
Compare
NicholaiVogel
force-pushed
the
hermes/hermes-7fefc18b
branch
from
September 17, 2026 12:29
aea5589 to
2ed04e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/var//tmp//etccanonicalization without weakening symlink checksrenameatx_npprimitives for no-replace installs and atomic directory exchangebun.lockfor Bun 1.3macos-14) and Intel (macos-15-intel)Validation
Local validation on macOS 26.5, Intel x86_64:
cargo buildcargo build --features test-hooks --target-dir target/test-hookscargo test --all-targetscargo clippy --all-targets --all-features -- -D warningsbunx tsc --noEmitbun install --frozen-lockfile --ignore-scriptsbun test --max-concurrency=1 --timeout=30000— 85 passed, 0 failedCI validation added by
.github/workflows/macos.yml: