Conversation
Signed-off-by: Vamsi-klu <nrvamsi13@gmail.com>
Author
|
@cmgoffena13 @tripleaceme — could you review this? It touches LSP startup, configuration listeners, and packaged configuration E2E coverage related to your recent work in these areas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Honor VS Code's global telemetry preference in every SQLMesh process launched by the extension.
SQLMESH__DISABLE_ANONYMIZED_ANALYTICS=truewhen VS Code telemetry is disabled, while preserving existing SQLMesh opt-outs when it is enabled.Fixes #5690
Test Plan
pnpm exec vitest run --maxWorkers=1 --minWorkers=1— 30 tests passed across 6 filespnpm run check-types— passedpnpm exec tsc --noEmit --project tsconfig.json— passedpnpm exec eslint tests/utils_code_server.ts tests/configuration.spec.ts— passedpnpm exec playwright test tests/configuration.spec.ts --reporter=line— 5 passedgit diff --check— passedChecklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO