[drivers][block] Keep I/O inside the logical partition - #11824
manyangshen wants to merge 1 commit into
Conversation
Reject negative offsets and requests exceeding the remaining partition sectors before forwarding them to the parent disk. Use subtraction to avoid overflow when checking the request end. Refs RT-Thread#11286
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: @Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2026-09-22 18:48 CST)
📝 Review Instructions
|
db5f782 to
ad71903
Compare
拉取/合并请求描述:(PR description)
For a partition starting at sector 40 with 100 sectors, a request at relative sector 99 for 2 sectors currently reaches the parent and crosses the partition boundary.
Check the relative sector against the partition length, then compare the request count with the remaining sectors. Subtraction avoids overflowing an end-sector calculation. Parent return values and zero-length requests at the end are preserved.
Refs #11286. Merged PR #11384 handles MBR parsing; this change addresses the remaining logical-device I/O checks.
Validation
GCC 16.1 compiles the complete blk_dev.c with repository headers and a memory-disk adapter. All 42 read/write cases pass, including exact fits, rejected boundary crossings, negative/large arguments, parent errors and short results. The original code fails. Uncalled registration/control functions are removed by LTO.
Changed-line clang-format and git diff --check pass. No target BSP, QEMU or storage hardware test was run.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up