Use the solid blue in light mode and fix the self-referencing font variable - #63
Merged
Merged
Conversation
White on #3c7dff is 3.77:1 and fails WCAG AA, so filled controls and blue text on white now use --ds-primary-solid (#3366fc, 4.72:1). #3c7dff stays the brand and signal blue on dark. Follows NextCommerceCo/design-system#2. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DfUoyGsC1hrfa8v6VHhD3h
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
developer-docs | c2dce0e | Commit Preview URL Branch Preview URL |
Sep 29 2026, 08:15 AM |
next-devin
marked this pull request as ready for review
September 29, 2026 07:21
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous Review Summary (commit 9a7cc55)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 9a7cc55)Status: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by minimax-m3 · Input: 0 · Output: 0 · Cached: 0 |
White on #3c7dff (dark fd-primary) is 3.77:1. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DfUoyGsC1hrfa8v6VHhD3h
alexphelps
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Devin · project thread
Before: in light mode, links, active nav items and filled buttons use
#3c7dff, which is 3.77:1 on white and fails WCAG AA.:rootalso sets--font-sans: var(--font-sans). That declaration refers to itself, so it is invalid and competes with the Inter variable that next/font puts on<html>.After: light mode uses the solid blue
#3366fc(4.72:1), and dark mode keeps#3c7dff. Inter is registered as--font-interand--font-sanspoints at it, the same way the docs repo wires it.This follows the org token contract in NextCommerceCo/design-system#2. The 1760px layout and 370px sidebar are left as they are.
How:
app/globals.csschanges the:rootprimary and the font line.app/layout.tsxrenames the next/font variable.🤖 Generated with Claude Code
https://claude.ai/code/session_01DfUoyGsC1hrfa8v6VHhD3h
Generated by Claude Code