Skip to content

Raise TypeError for a bad subprocess pipe protocol owner - #767

Open
gyanu2507 wants to merge 1 commit into
MagicStack:masterfrom
gyanu2507:fix/subprocess-pipe-proto-type
Open

gyanu2507 wants to merge 1 commit into
MagicStack:masterfrom
gyanu2507:fix/subprocess-pipe-proto-type

Conversation

@gyanu2507

Copy link
Copy Markdown

Fixes #765.

ReadSubprocessPipeProto and WriteSubprocessPipeProto only checked proc and fd when UVLOOP_DEBUG was set. A bad proc was then cast to UVProcessTransport and the process segfaulted. That check now always runs, so the call in the report raises TypeError instead.

The constructor only checked proc and fd under UVLOOP_DEBUG, then cast proc and segfaulted. That check now always runs.

Fixes MagicStack#765.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Directly constructed subprocess pipe protocols segfault when callbacks use a non-process owner

1 participant