Skip to content

Record failed checks when speed testing is enabled - #34

Merged
DavidVoitenko merged 3 commits into
mainfrom
fix/speedtest-failed-results-33
Sep 28, 2026
Merged

DavidVoitenko merged 3 commits into
mainfrom
fix/speedtest-failed-results-33

Conversation

@DavidVoitenko

@DavidVoitenko DavidVoitenko commented Sep 28, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Save failed basic proxy checks immediately when optional speed or anonymity checks are configured. A failed basic check never enters the expensive stage, so deferring its write had left progress at zero and job items pending.
  • Add a real socket regression with eight local proxy endpoints: each accepts TCP, seven never answer the target request, and one answers the target but stalls on the speed URL. The CLI now records all eight results and observations, leaves no pending job items, and records an error for the failed speed measurement.
  • Prepare patch release 3.0.4 with updated version references and changelog.

Verification

  • Before the fix, the focused regression showed Checked 0/8 and no saved rows; after the fix, it records 8/8.
  • Full local suite: 3,723 tests passed, 2 skipped.
  • The socket regression passes with warnings treated as errors.

Addresses #33. A working proxy whose speed download never responds still uses the configured speed probe timeout; the fix keeps all completed basic failures visible and durable.

@DavidVoitenko
DavidVoitenko marked this pull request as ready for review September 28, 2026 09:17
@DavidVoitenko
DavidVoitenko merged commit dd2c33b into main Sep 28, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant