Skip to content

Preserve Jetty 12 request task invocation types - #12586

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/jetty-preserve-invocation-type
Sep 22, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/jetty-preserve-invocation-type

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

What Does This Do

JettyRunnableWrapper hides the wrapped task’s Invocable contract, causing Jetty to classify every wrapped task as blocking. For nonblocking HTTP/2 handlers, this can introduce unnecessary executor dispatch or producer handoffs.

Implement Invocable on the wrapper and delegate getInvocationType() to the original task, preserving Jetty’s scheduling decisions and existing context propagation.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali
amarziali requested a review from a team as a code owner September 21, 2026 12:47
@amarziali
amarziali removed the request for review from a team September 21, 2026 12:47
@amarziali amarziali added the type: bug fix Bug fix label Sep 21, 2026
@amarziali amarziali added the inst: jetty Jetty instrumentation label Sep 21, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-21T12:50:41.738394Z c377bc4 PR opened
🔒 Security Review ✅ Completed 2026-09-21T12:52:16.231179Z c377bc4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@amarziali

Copy link
Copy Markdown
Contributor Author

@DataDog review

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The wrapper keeps each Jetty invocation type. Plain Runnable tasks keep the blocking default, and context handling stays unchanged.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit c377bc4 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-datadog-prod-us1-2

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.02 s 14.02 s [-0.7%; +0.6%] (no difference)
startup:insecure-bank:tracing:Agent 12.98 s 13.04 s [-1.3%; +0.3%] (no difference)
startup:petclinic:appsec:Agent 17.59 s 17.32 s [+0.7%; +2.5%] (maybe worse)
startup:petclinic:iast:Agent 17.46 s 17.69 s [-2.1%; -0.6%] (maybe better)
startup:petclinic:profiling:Agent 17.41 s 17.47 s [-1.5%; +0.8%] (no difference)
startup:petclinic:sca:Agent 17.63 s 17.59 s [-0.7%; +1.1%] (no difference)
startup:petclinic:tracing:Agent 16.80 s 16.76 s [-0.9%; +1.3%] (no difference)

Commit: c377bc4f · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The wrapper delegates Jetty invocation types and keeps plain Runnable tasks blocking. Context propagation stays unchanged.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit c377bc4 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@vandonr
vandonr removed the request for review from ValentinZakharov September 22, 2026 11:29
@amarziali

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-22 11:49:20 UTC ℹ️ Start processing command /merge


2026-09-22 11:49:24 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-22 13:15:57 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit aeea187 into master Sep 22, 2026
608 of 611 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the andrea.marziali/jetty-preserve-invocation-type branch September 22, 2026 13:15
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: jetty Jetty instrumentation type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants