Preserve Jetty 12 request task invocation types - #12586
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@DataDog review |
There was a problem hiding this comment.
More details
The wrapper keeps each Jetty invocation type. Plain Runnable tasks keep the blocking default, and context handling stays unchanged.
🤖 Datadog Autotest · Commit c377bc4 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
More details
The wrapper delegates Jetty invocation types and keeps plain Runnable tasks blocking. Context propagation stays unchanged.
🤖 Datadog Autotest · Commit c377bc4 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
aeea187
into
master
What Does This Do
JettyRunnableWrapperhides the wrapped task’sInvocablecontract, causing Jetty to classify every wrapped task as blocking. For nonblocking HTTP/2 handlers, this can introduce unnecessary executor dispatch or producer handoffs.Implement
Invocableon the wrapper and delegategetInvocationType()to the original task, preserving Jetty’s scheduling decisions and existing context propagation.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]