Skip to content

Migrate telemetry groovy files to java part 3 - #12585

Open
jpbempel wants to merge 1 commit into
masterfrom
jpbempel/g2j-telemetry-pt3
Open

jpbempel wants to merge 1 commit into
masterfrom
jpbempel/g2j-telemetry-pt3

Conversation

@jpbempel

Copy link
Copy Markdown
Member

What Does This Do

we migrate 8 tests:

  • DependencyPeriodActionTest
  • DependencyResolverQueueTest
  • DependencyResolverTest
  • DependencyResolverTest
  • JarReaderTest
  • LocationsCollectingTransformerTest
  • EndpointPeriodicActionTest
  • LogPeriodicActionTest

Motivation

this is part of the effort to migrate groovy tests to Java/JUnit
part1: #12430
part2: #12461

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

we migrate 8 tests:
- DependencyPeriodActionTest
- DependencyResolverQueueTest
- DependencyResolverTest
- DependencyResolverTest
- JarReaderTest
- LocationsCollectingTransformerTest
- EndpointPeriodicActionTest
- LogPeriodicActionTest
@jpbempel
jpbempel requested a review from a team as a code owner September 21, 2026 11:48
@jpbempel
jpbempel requested review from AlexeyKuznetsov-DD and removed request for a team September 21, 2026 11:48
@dd-octo-sts

dd-octo-sts Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@jpbempel jpbempel added comp: testing Testing type: refactoring tag: no release notes Changes to exclude from release notes labels Sep 21, 2026

@datadog-prod-us1-6 datadog-prod-us1-6 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The Java tests keep the behavior of the removed Groovy tests. The production code change only makes convertToURI visible to package tests.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit ad46be5 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Sep 21, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 57.97% (-1.15%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ad46be5 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.82 s 14.66 s [+0.3%; +2.0%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.59 s 13.64 s [-1.0%; +0.3%] (no difference)
startup:petclinic:appsec:Agent 17.03 s 16.98 s [-0.8%; +1.3%] (no difference)
startup:petclinic:iast:Agent 16.96 s 17.09 s [-1.5%; -0.0%] (maybe better)
startup:petclinic:profiling:Agent 16.79 s 16.76 s [-1.1%; +1.3%] (no difference)
startup:petclinic:sca:Agent 17.00 s 16.82 s [-0.0%; +2.1%] (no difference)
startup:petclinic:tracing:Agent 16.05 s 16.17 s [-1.6%; +0.2%] (no difference)

Commit: ad46be56 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@jpbempel jpbempel changed the title Migrate telemetry groovy files to java part 2 Migrate telemetry groovy files to java part 3 Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant