Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The change preserves request-context lifecycle behavior while it reuses Netty attribute containers. The static reviewer found no reportable defect in request reuse or HTTP/2 context transfer.
🤖 Datadog Autotest · Commit c5c7b38 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
What Does This Do
Clear HTTP request-context attribute values instead of removing their containers. This avoids recreating attributes and updating Netty’s attribute map on subsequent keep-alive requests.
Adjust HTTP/2 context transfer to ignore empty retained parent attributes while preserving existing child contexts. Channel-close cleanup remains unchanged.
JMH results for the two attribute lifecycles used per request:
Measured using real
EmbeddedChannelattributes, 32 rotating context values, JMH 1.37, Temurin 17.0.18, and Apple M4 Max. Three forks, three 1-second warmup iterations, four 1-second measurement iterations, one thread, a 512 MiB heap, and the GC profiler. Timing confidence intervals do not overlap.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]