Conversation
- Add /dd-java-agent/instrumentation/**/*appsec*, **/*AppSec*, **/*iast* patterns co-owned by asm-java + apm-idm-java, closing a case-sensitivity/ substring gap that misrouted nested lowercase-hyphenated modules (e.g. jetty-appsec-11.0) and CamelCase files (e.g. AppSecInterceptor.java) to apm-idm-java-only review. - Add **/*rasp* preventively (no live bug found; all current RASP code uses capitalized "Rasp"). - Remove lines now subsumed by the new wildcard patterns.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
More details
The new patterns preserve the removed path coverage. They also route lowercase nested module names and CamelCase AppSec files to both owner teams.
🤖 Datadog Autotest · Commit 0059d45 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
jordan-wong
left a comment
There was a problem hiding this comment.
LGTM, thanks for this PR!
What Does This Do
/dd-java-agent/instrumentation/**/*appsec*and**/*iast*(lowercase, wildcard both sides) co-owned by@DataDog/asm-java @DataDog/apm-idm-java, so nested modules named with lowercase-hyphenated style (e.g.jetty-appsec-11.0,akka-http-10.2-iast) are no longer routed toapm-idm-javaonly./dd-java-agent/instrumentation/**/*AppSec*(CamelCase), same owners, so standalone files inside generic framework modules (e.g.AppSecInterceptor.javaunder okhttp/spring-webmvc/spring-security/tomcat/jetty-server/liberty/grizzly/jersey/ratpack/vertx-web) are also routed correctly.**/*Iast*and**/*Rasp*(CamelCase) already existed./dd-java-agent/instrumentation/**/*rasp*(lowercase) preventively — no RASP file currently uses lowercase naming, but this closes the same class of gap before it can regress.**/appsec/,**/iast/,**/rasp/, flat*iast*, flat*appsec*. Confirmed with apathspec-based last-match-wins simulator (run against the full file, matching GitHub's actual resolution semantics) that the new patterns are a strict superset of what was removed.Motivation
APPSEC-70201 reported AppSec/IAST-owned code being routed to
@DataDog/apm-idm-javainstead of@DataDog/asm-java. The ticket's original root cause (*not crossing/) had already been fixed by #12276 before this PR; the live gap that remained was narrower: case-sensitivity / substring-wildcarding for lowercase-hyphenated modules and a missing**/*AppSec*CamelCase pattern. This PR closes that remaining gap. The decoupling work described as "Problem 2" in the same ticket (BlockResponseFunction consolidation) is explicitly out of scope for this PR.Additional Notes
kafka-clients-0.11/src/test/groovy/iast/, which a laterdata-streams-monitoringrule also matches) still resolves to that later rule due to CODEOWNERS' last-match-wins semantics. Fixing it would require reordering/auditing the whole file's section precedence — a separate, larger task.gh api repos/DataDog/dd-trace-java/codeowners/errorsreturned{"errors":[]}against the pushed branch (syntax check).Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-70201
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.