Skip to content

[WIP] Add lint rule to enforce broad-catch justification - #12569

Draft
dd-apm-ecosystems[bot] wants to merge 3 commits into
masterfrom
automated/lint-broad-catch-swallow-20260918
Draft

dd-apm-ecosystems[bot] wants to merge 3 commits into
masterfrom
automated/lint-broad-catch-swallow-20260918

Conversation

@dd-apm-ecosystems

@dd-apm-ecosystems dd-apm-ecosystems Bot commented Sep 18, 2026

Copy link
Copy Markdown

| Unjustified broad catch (Throwable/Exception ...) that swallows the failure with no logging, no rethrow, and no comment (also swallows JVM-fatal errors like OutOfMemoryError) | 9 (#11639, #12028, #12052, #12247, #12248, #12330, #12346, #12432, #12493, #12527, #12557) | ✅ Yes — mechanically detectable via diff-scoped text/regex analysis, low false-positive risk |

Blocker encountered: All four non-workflow files were committed successfully to branch automated/lint-broad-catch-swallow-20260918. However, writing the actual .github/workflows/*.yaml file was rejected (403 Forbidden: Resource not accessible by integration) because my GitHub write credentials lack the workflow OAuth scope required to create/modify workflow files, and the Dev Agent's create_or_update_pr tool is blocked by policy for this public repository. I opened a draft PR with what could be pushed: #12569

This PR is incomplete — it is missing .github/workflows/enforce-broad-catch-justification.yaml, the file that actually wires the check into CI. A human maintainer needs to either grant workflow-write scope to the automation credentials, or manually add that one file (content is fully specified in the coding session at https://app.datadoghq.com/code/919f3070-a007-40a0-b753-39207804fb44) before this can be considered a complete, mergeable enforcement rule. I'm flagging this explicitly rather than claiming full completion.

@datadog-official

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.08 s 14.04 s [-0.4%; +0.8%] (no difference)
startup:insecure-bank:tracing:Agent 12.95 s 13.04 s [-1.3%; +0.0%] (no difference)
startup:petclinic:appsec:Agent 17.05 s 16.90 s [-0.0%; +1.8%] (no difference)
startup:petclinic:iast:Agent 16.95 s 16.98 s [-1.0%; +0.7%] (no difference)
startup:petclinic:profiling:Agent 16.60 s 16.60 s [-1.1%; +1.0%] (no difference)
startup:petclinic:sca:Agent 16.78 s 16.93 s [-1.7%; +0.0%] (no difference)
startup:petclinic:tracing:Agent 16.12 s 16.14 s [-1.2%; +0.9%] (no difference)

Commit: 2c171d79 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants