Skip to content

Avoid Netty queue-timing metadata reads before JFR is ready - #12558

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
andrea.marziali/netty-queue-timing-readiness
Sep 21, 2026
Merged

Avoid Netty queue-timing metadata reads before JFR is ready#12558
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
andrea.marziali/netty-queue-timing-readiness

Conversation

@amarziali

@amarziali amarziali commented Sep 18, 2026 •
edited by bric3
Loading

Copy link
Copy Markdown
Contributor

What Does This Do

Reuse QueueTimerHelper.isReady() from the preceding PR (#12550) to skip unnecessary work in Netty’s ordinary, delayed and scheduled queue-timing advice.

Before JFR is ready, this avoids context-store lookups, queue-size reads and scheduler metadata collection. The readiness check remains dynamic to support delayed profiling startup.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali
amarziali added this pull request to stack #12559 September 18, 2026 07:24
@amarziali
amarziali requested review from a team as code owners September 18, 2026 07:24
@amarziali
amarziali removed the request for review from a team September 18, 2026 07:24
@amarziali amarziali added the type: feature Enhancements and improvements label Sep 18, 2026
@amarziali
amarziali requested a review from bric3 September 18, 2026 07:24
@amarziali amarziali added the comp: profiling Profiling label Sep 18, 2026
@amarziali
amarziali requested review from jbachorik and vandonr and removed request for a team September 18, 2026 07:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-18T07:27:14.501659Z c80ba43 PR opened
🔒 Security Review ✅ Completed 2026-09-18T07:28:45.389520Z c80ba43 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Sep 18, 2026 •
edited by datadog-prod-us1-4 Bot
Loading

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.09% (-0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c80ba43 | Docs | Give us feedback!

datadog-prod-us1-5[bot]
datadog-prod-us1-5 Bot reviewed Sep 18, 2026
View reviewed changes

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The readiness guards stop metadata reads before JFR is ready. They keep trace propagation active and support delayed profiling startup.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit c80ba43 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@dd-octo-sts

dd-octo-sts Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.80 s 14.77 s [-0.6%; +1.0%] (no difference)
startup:insecure-bank:tracing:Agent 13.70 s 13.74 s [-1.0%; +0.5%] (no difference)
startup:petclinic:appsec:Agent 17.05 s 16.83 s [+0.4%; +2.2%] (maybe worse)
startup:petclinic:iast:Agent 17.00 s 17.05 s [-1.0%; +0.5%] (no difference)
startup:petclinic:profiling:Agent 16.54 s 16.86 s [-3.0%; -0.9%] (maybe better)
startup:petclinic:sca:Agent 17.03 s 16.79 s [+0.5%; +2.3%] (maybe worse)
startup:petclinic:tracing:Agent 16.03 s 16.12 s [-1.6%; +0.4%] (no difference)

Commit: c80ba43f · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

bric3
bric3 approved these changes Sep 18, 2026
View reviewed changes
Comment thread ...tadog/trace/instrumentation/netty40/concurrent/SingleThreadEventExecutorInstrumentation.java
@amarziali
amarziali added this pull request to the merge queue Sep 21, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-21 09:39:55 UTC ℹ️ Start processing command /merge

2026-09-21 09:39:57 UTC ℹ️ MergeQueue: Stack detected — automatically merging the entire stack.

2026-09-21 09:40:02 UTC ℹ️ Devflow: Merging stacked PRs in the following order:

  1. Avoid queue-timing metadata reads before JFR is ready (#12550)
  2. Avoid Netty queue-timing metadata reads before JFR is ready (#12558)

Progress updates will be sent here directly.

2026-09-21 09:40:03 UTC ℹ️ Devflow: Merging Avoid queue-timing metadata reads before JFR is ready (#12550)...

2026-09-21 09:40:06 UTC ❌ MergeQueue

merge method 'merge' is not allowed for this repository. Supported methods are: [squash]

2026-09-21 09:40:07 UTC ❌ MergeQueue

The following PRs won't be merged. The current stack is:

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Sep 21, 2026
Base automatically changed from andrea.marziali/skip-ineligible-queue-timing to master September 21, 2026 10:52
datadog-prod-us1-5[bot]
datadog-prod-us1-5 Bot reviewed Sep 21, 2026
View reviewed changes

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The readiness guards preserve trace propagation. They prevent queue metadata reads before JFR initialization.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit c80ba43 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@amarziali amarziali added the tag: override groovy enforcement Override the "Enforce Groovy Migration" check label Sep 21, 2026
@amarziali

amarziali commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-21 12:29:19 UTC ℹ️ Start processing command /merge

2026-09-21 12:29:25 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-09-21 12:54:10 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 3a8b393:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@amarziali

amarziali commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-21 12:59:58 UTC ℹ️ Start processing command /merge

2026-09-21 13:00:03 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-09-21 13:56:42 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 81d4706 into master Sep 21, 2026
618 of 622 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the andrea.marziali/netty-queue-timing-readiness branch September 21, 2026 13:56
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datadog-prod-us1-5 datadog-prod-us1-5[bot] datadog-prod-us1-5[bot] left review comments
@jbachorik jbachorik jbachorik approved these changes
@bric3 bric3 bric3 approved these changes
@vandonr vandonr vandonr approved these changes

Assignees

No one assigned

Labels

comp: profiling Profiling tag: override groovy enforcement Override the "Enforce Groovy Migration" check type: feature Enhancements and improvements

Projects

None yet

Milestone

1.67.0

Development

Successfully merging this pull request may close these issues.

4 participants

@amarziali @jbachorik @bric3 @vandonr