Conversation
ab9rf
approved these changes
Jul 11, 2026
Member
|
This looks good except for one thing: it needs a changelog |
Member
|
After some consideration, I've decided that this is too risky to add without some safety measures - it would be far too easy for someone to use this to do significant damage. Some sort of protection to limit what files can be removed seems necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes \std::filesystem::remove_all\ to Lua as \dfhack.filesystem.rmdir_recursive.
Required for PR DFHack/scripts#1583 (\manual-save) to implement the --cleanup\ snapshot pruning feature natively.