Skip to content

Herdr support not working on windows #913

Description

@shunia

Summary

It's not working since the herdr support is introduced, I have tried to locate the issue by then but forget to post the issue. Now I'm here to provide the finding through AI:

HERDR_SOCKET_PATH is a regular file, not a named pipe. Its contents are a rendezvous string:

  17472:1789874021129905200

  That is <herdr-server-pid>:<nonce>. The herdr CLI reads this file and connects to the real endpoint; the path itself is not
  connectable.

  sendHerdrLine() in dist/cli.mjs hands that path straight to net.createConnection():

  const o = he.createConnection(e.socketPath);

  On Windows this can't work. Node/libuv treats a filesystem path as a pipe name, so it tries something like \\.\pipe\C:\Users\...
  \herdr.sock and fails immediately. The error is swallowed by design (o.on("error", s), a 250 ms timeout, and .catch(() => {})),
  so the integration fails silently and the user sees nothing.

Please help fix this. Before the native support, I use third party plugin and it works somehow, now it totally breaks.

Expected Behavior

Herdr should show cmdc session in the bottom left corner by default on Windows like on Linux or Mac

Actual Behavior

Herdr does not show any cmdc session on Windows.

Steps to reproduce the issue

  1. Install the latest version of herdr
  2. Install latest version of command-code
  3. Start herdr
  4. Start a cmdc session
  5. Check out the agents panel, cmdc session does not listed there

Command Code Version

1.62.0

Operating System

Windows

Terminal/IDE

No response

Shell

No response

Session file (optional)

No response

Fix prompt (optional)

No response

Additional context

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions