Phase 1 foundations by ShashiDao · Pull Request #2939 · Acode-Foundation/Acode

ShashiDao · 2026-09-25T11:32:39Z

No description provided.

…ents, patches)

docs: sub-phase the roadmap, easy to tough

… AGENTS.md)

…affold (workflow-scope blocked, see staged file header)

…scaffold-android-workflow.yml)

This workflow scaffolds the Android platform by checking out the repository, setting up dependencies, generating the Android platform, and applying necessary overrides and configurations. It also commits changes and opens a pull request for review.

Updated the intent-filter format for better readability and maintainability in the AndroidManifest.xml.

…its the acronym+plural into "PN"+"Gs" and flags "PN" as a misspelling of "ON", failing CI spell-check

…011 overrides

Phase 0.2: native Android scaffold

Verified locally: config.js -> rspack -> `npx cap sync android` all run clean against the merged android/ scaffold (20 Cordova plugins bridged automatically, boot.js lands in assets/public). Only `cordova build` itself was still wired to the removed Cordova platform model. fdroid proot/iap `cordova plugin add/remove` calls left as-is for now — they're currently no-ops under Capacitor (it reads plugins from package.json/node_modules, not the `plugins/` cache dir cordova CLI still writes to). Flagging as a follow-up, not fixing here.

chore: verify android-build CI (throwaway)

Added CI badge to README for build status visibility.

… closed)

* Fix permission issue for gradlew in CI workflow * fix(android): resolve FileProvider manifest merge conflict with ported Cordova plugin capacitor-cordova-android-plugins (generated by `cap sync` from the 20 bridged plugins) brings in a second FileProvider declaration under the old Acode identity (authorities=com.foxdebug.provider, resource=@xml/file_provider) that collides with Bract's own (${applicationId}.fileprovider, @xml/file_paths). Manifest merger can't auto-resolve two different values for the same attribute, so add the tools:replace overrides Gradle itself suggests in the error log, keeping Bract's own FileProvider identity (ADR-011) authoritative.

…e Maverick/BouncyCastle classes compile under Capacitor.

greptile-apps · 2026-09-25T11:37:49Z

Confidence Score: 2/5

[High risk] Replaces build system and CI infrastructure.

The PR is not ready to merge because the Android build may fail resource linking, and CI does not package the generated web entry point.

Findings

Theme colors are undefined ▶
APK lacks its web entry ▶
Bundle option changes artifact type ▶
Instrumented test expects wrong package ▶

Summary

The PR establishes Bract’s Capacitor Android scaffold, switches CI and build scripts toward Bun and Gradle, and records the migration plan. The Android build still needs defined theme colors and a web-build step in CI; the bundle option also changes artifact type.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[CI checkout] --> B[Bun install]
  B --> C[Capacitor sync]
  C --> D[Gradle assembleDebug]
  E[Rspack generates boot.js] -. missing CI step .-> C
  D --> F[APK loads index.html]
  F --> G[Requests build/boot.js]

_{Reviews (1) · Last reviewed commit: "Complete Phase 0.2 documentation and Bra..."}

greptile-apps · 2026-09-25T11:37:53Z

+        <item name="colorPrimary">@color/colorPrimary</item>
+        <item name="colorPrimaryDark">@color/colorPrimaryDark</item>
+        <item name="colorAccent">@color/colorAccent</item>


Theme colors are undefined

The new theme references colorPrimary, colorPrimaryDark, and colorAccent, but the checked-in Android resources define none of them. If no dependency supplies all three colors, Android resource linking will fail and the Gradle build cannot produce an APK. Define these colors in the app’s resources.

greptile-apps · 2026-09-25T11:37:53Z

+      - name: Sync Capacitor
+        if: steps.android-check.outputs.exists == 'true'
+        run: npx cap sync android


APK lacks its web entry

On a clean CI checkout, www/build/boot.js is absent because it is generated by Rspack and ignored by Git. This job syncs www without building it first, so Gradle can produce an APK whose index.html requests a missing script. The app then cannot start. Build the web assets before syncing them.

greptile-apps · 2026-09-25T11:37:53Z

+if [ "$packageType" = "bundle" ]; then
+  gradleTask="bundle"
+else
+  gradleTask="assemble"
+fi


Bundle option changes artifact type

When someone selects bundle, this script now runs an app-bundle task on an Android application module. That produces an AAB instead of the AAR library the option still promises, so callers expecting a library will not receive one. Preserve the AAR build path or rename and document this option as an app bundle.

greptile-apps · 2026-09-25T11:37:53Z

+        // Context of the app under test.
+        Context appContext = InstrumentationRegistry.getInstrumentation().getTargetContext();
+
+        assertEquals("com.getcapacitor.app", appContext.getPackageName());


Instrumented test expects wrong package

This test expects com.getcapacitor.app, but the app’s application ID is io.github.shashidao.bract. Running the Android instrumented tests will fail this assertion even when the installed app is correct, making the test unusable until the expectation is updated.

Suggested change

assertEquals("com.getcapacitor.app", appContext.getPackageName());

assertEquals("io.github.shashidao.bract", appContext.getPackageName());

UnschooledGamer

Rejected, Discuss before opening a Pull Request for such things, Especially when it's AI-Generated PRs wasting the Maintainers time with low quality PRs and the time that can be used for the Community.

This will be your second warning, if the third one happens to be similar to these 2 PRs, You'll be restricted from the Organization.

ShashiDao · 2026-09-25T18:00:27Z

Oh my god it was actually a mistake i was planned to open pr on my repo branch where I'm forking and due to I'm working inside phone it happened to miss clicked. Sorry mate.

ShashiDao added 30 commits September 25, 2026 11:30

docs: add project scaffold (blueprint, status, roadmap, decisions, ag…

8387761

…ents, patches)

docs: add Bract project banner to readme, link to docs scaffold

81bb410

docs: add full product blueprint

5c51ca9

docs: log ADR-003 (Cordova to Capacitor) and ADR-004 (Svelte for new UI)

7264676

docs: revise blueprint for Capacitor shell + Svelte UI decision (v0.2)

5c3ec6a

docs: add Capacitor migration + cleanup items to Phase 0

0dcf53a

docs: update status for Capacitor migration kickoff

0dbda08

docs: update AGENTS.md ground rules for harvest-not-rebase model

fbba864

docs: reframe PATCHES.md as a provenance log per ADR-003

291b74c

docs: break roadmap phases into sub-phases, sequenced easy to tough

2cd7290

docs: point STATUS at new Phase 0 sub-phase sequence

65f96a5

Merge pull request #1 from ShashiDao/docs/phase-subphase-roadmap

a1cafcb

docs: sub-phase the roadmap, easy to tough

chore: remove Acode-Foundation CODEOWNERS

0e25812

chore: remove Acode nightly-build release workflow

71025b1

chore: remove Acode nightly-release workflow

68cf916

chore: remove Acode on-demand preview release workflow

5790a0b

chore: remove Acode community-release-notifier workflow

7937bdc

chore: remove Acode-Foundation-gated congrats bot workflow

29cea0a

chore: remove Acode-Foundation CODE_OF_CONDUCT

22bbf60

chore: remove redundant package-lock.json (bun.lock is canonical, per…

3c55d9a

… AGENTS.md)

chore: remove Acode fastlane store metadata

329dc87

chore: remove Acode fastlane store metadata

ab8110d

chore: remove Acode fastlane store metadata

fdcf54b

chore: remove Acode fastlane store metadata

c06b292

chore: remove Acode fastlane store metadata

d582172

chore: remove Acode fastlane store metadata

6f383e0

chore: remove Acode fastlane store metadata

449e718

chore: remove Acode fastlane store metadata

f5c58d3

chore: remove Acode fastlane store metadata

3ea0b9f

chore: remove Acode fastlane store metadata

d5443d1

ShashiDao and others added 22 commits September 25, 2026 14:04

docs: stage one-time GitHub Action to generate the native android/ sc…

cc84ce2

…affold (workflow-scope blocked, see staged file header)

docs: STATUS reflects staged Android-scaffold workflow (docs/pending-…

2962bea

…scaffold-android-workflow.yml)

Delete docs/pending-scaffold-android-workflow.yml

aa04518

docs: STATUS reflects scaffold-android.yml landed + staging doc removed

7966902

Refactor intent-filter in scaffold-android.yml

6f19b63

Updated the intent-filter format for better readability and maintainability in the AndroidManifest.xml.

fix(docs): reword "PNGs" to "PNG images" in STATUS.md — typos-cli spl…

265c6b1

…its the acronym+plural into "PN"+"Gs" and flags "PN" as a misspelling of "ON", failing CI spell-check

Update scaffold-android.yml

686f779

Phase 0.2: generate Android platform (cap add android) + ADR-008/ADR-…

138bb7e

…011 overrides

Merge pull request #5 from ShashiDao/phase-0.2-android-scaffold

a7ddc1b

Phase 0.2: native Android scaffold

Delete .github/workflows/scaffold-android.yml

1f52334

chore: trigger android-build CI check

c4d4fdd

Add Android platform checks and setup in CI workflow

b20b6cb

Merge pull request #6 from ShashiDao/ci/verify-android-build

92b480d

chore: verify android-build CI (throwaway)

Add CI badge to README

8a02577

Added CI badge to README for build status visibility.

chore: remove throwaway CI_VERIFY_TMP.md (PR #6 got merged instead of…

c5d1d6a

… closed)

Upgrade JDK version from 17 to 21 in CI workflow (#8)

36df541

Add the missing SFTP/SSH native dependencies to the Android app so th…

40f0529

…e Maverick/BouncyCastle classes compile under Capacitor.

Update readme.md (#9)

0c6f803

Complete Phase 0.2 documentation and Bract web-shell identity cleanup.

3511f80

ShashiDao requested a review from UnschooledGamer as a code owner September 25, 2026 11:32

github-project-automation Bot added this to The Code Board - Acode Sep 25, 2026

github-actions Bot added the docs label Sep 25, 2026

ShashiDao closed this Sep 25, 2026

greptile-apps Bot reviewed Sep 25, 2026

View reviewed changes

UnschooledGamer requested changes Sep 25, 2026

View reviewed changes

Navigation Menu

Phase 1 foundations - #2939

Phase 1 foundations#2939
ShashiDao wants to merge 73 commits into
Acode-Foundation:mainfrom
ShashiDao:phase-1-foundations

ShashiDao commented Sep 25, 2026

Uh oh!

greptile-apps Bot commented Sep 25, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot Sep 25, 2026

Uh oh!

greptile-apps Bot Sep 25, 2026

Uh oh!

greptile-apps Bot Sep 25, 2026

Uh oh!

greptile-apps Bot Sep 25, 2026

Uh oh!

UnschooledGamer left a comment

Uh oh!

ShashiDao commented Sep 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	assertEquals("com.getcapacitor.app", appContext.getPackageName());
	assertEquals("io.github.shashidao.bract", appContext.getPackageName());

Conversation

ShashiDao commented Sep 25, 2026

Uh oh!

greptile-apps Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 2/5

Findings

Summary

Diagram

Uh oh!

greptile-apps Bot Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

UnschooledGamer left a comment

Choose a reason for hiding this comment

Uh oh!

ShashiDao commented Sep 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps Bot commented Sep 25, 2026 •

edited

Loading