Skip to content

Docs/phase 0.1 decisions - #2937

Closed
ShashiDao wants to merge 41 commits into
Acode-Foundation:mainfrom
ShashiDao:docs/phase-0.1-decisions
Closed

ShashiDao wants to merge 41 commits into
Acode-Foundation:mainfrom
ShashiDao:docs/phase-0.1-decisions

Conversation

@ShashiDao

Copy link
Copy Markdown

No description provided.

docs: sub-phase the roadmap, easy to tough
@greptile-apps

greptile-apps Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 2/5

[Low risk] Documentation and repository housekeeping for a project fork.

This PR is not safe to merge while it removes active release and preview workflows and leaves PR CI unable to install dependencies.

Findings

  1. P2 Settled decisions appear open ▶

Summary

The PR adds Bract architecture, roadmap, decision, and status documents while removing Acode release automation, store metadata, and the npm lockfile.

  • Removing workflows from the Acode repository stops its nightly releases and on-demand PR previews.
  • Removing the npm lockfile before migrating active CI breaks PR dependency installation.
  • STATUS and ROADMAP still mark decisions accepted in ADR-006 as open.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  PR["PR label"] -->|deleted| Preview["Preview APK workflow"]
  Schedule["Daily schedule"] -->|deleted| Nightly["Nightly build and release"]
  Checks["Surviving PR CI"] --> Npm["npm ci"]
  Npm -->|root lockfile deleted| Failure["Dependency installation fails"]
Loading

Reviews (1) · Last reviewed commit: "docs: sync BLUEPRINT §2/§7/§11 with ADR-..."

Comment thread docs/STATUS.md

## In progress

- Phase 0.1's last item — the three remaining BLUEPRINT.md §11 decisions (distribution/monetization, team size and device floor, first three model providers) — needs the project owner's input, not something to resolve unilaterally.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Settled decisions appear open

This snapshot says distribution, monetization, and the Android device floor still need a decision, but ADR-006 accepts all three. ROADMAP repeats the outdated list. Since contributors are directed to use STATUS as the source of truth, this could send them back to resolve choices already made; only team size and model providers remain open.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@greptile-apps

greptile-apps Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Comments Outside Diff

These findings sit on lines the diff does not cover, so they could not be posted inline. Each one leaves this list once its file changes.

  • P1 Nightly releases stop .github/workflows/nightly-release.yml:1 ▶

    Deleting this workflow from acode-foundation/acode removes the daily trigger for building and publishing nightly APKs. No surviving workflow replaces it, so nightly releases and their community notifications stop.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

  • P1 PR preview builds disappear .github/workflows/on-demand-preview-releases-PR.yml:1 ▶

    Deleting this workflow removes the label-triggered preview APK build for Acode PRs. The surviving CI runs checks but does not produce a preview APK, so maintainers can no longer request one through the existing labels.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

  • P1 PR dependency installation fails package-lock.json:1 ▶

    The active PR unit-test job still runs npm ci at the repository root, but this change deletes the root npm lockfile. npm ci cannot install without one, so the unit-test check fails; the translation check can hit the same failure when it runs.

@UnschooledGamer UnschooledGamer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too Many Changes without a PR Description and thought process behind them, Please add PR Description explaining your thought about the changes you've made.

@ShashiDao ShashiDao closed this Sep 25, 2026
@ShashiDao
ShashiDao deleted the docs/phase-0.1-decisions branch September 25, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants