From 6f6ae4921a8ab591813cf56cacee103d770eb842 Mon Sep 17 00:00:00 2001
From: Matt Friedman <maf675@gmail.com>
Date: Mon, 28 Sep 2026 06:42:24 -0700
Subject: [PATCH] Fix up postgres and other tests

---
 .github/workflows/tests.yml | 32 +++++++++++---------------------
 1 file changed, 11 insertions(+), 21 deletions(-)

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 3fd262d..22e4750 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -380,7 +380,7 @@ jobs:
 
         services:
             postgres:
-                image: ${{ matrix.db != 'postgres:9.5' && matrix.db != 'postgres:9.6' && matrix.db != 'postgres:10' && matrix.db != 'postgres:11' && matrix.db != 'postgres:12' && matrix.db != 'postgres:13' && 'postgres:10' || matrix.db }}
+                image: ${{ matrix.db }}
                 env:
                     POSTGRES_HOST: localhost
                     POSTGRES_USER: postgres
@@ -389,7 +389,7 @@ jobs:
                     - 5432:5432
                 options: >-
                     -v /var/run/postgresql:/var/run/postgresql
-                    --health-cmd pg_isready
+                    --health-cmd "pg_isready -U postgres"
                     --health-interval 10s
                     --health-timeout 5s
                     --health-retries 5
@@ -512,18 +512,21 @@ jobs:
                 include:
                     - php: ${{ inputs.PRIMARY_PHP_VERSION }}
                       db: "sqlite3"
+                      db_image: ''
                     - php: ${{ inputs.PRIMARY_PHP_VERSION }}
-                      db: "mcr.microsoft.com/mssql/server:2019-CU27-ubuntu-20.04"
+                      db: "mssql"
+                      db_image: "mcr.microsoft.com/mssql/server:2019-CU27-ubuntu-20.04"
                       db_alias: 'MSSQL 2019'
                     - php: ${{ inputs.PRIMARY_PHP_VERSION }}
-                      db: "mcr.microsoft.com/mssql/server:2022-CU13-ubuntu-22.04"
+                      db: "mssql"
+                      db_image: "mcr.microsoft.com/mssql/server:2022-CU13-ubuntu-22.04"
                       db_alias: 'MSSQL 2022'
 
         name: PHP ${{ matrix.php }} - ${{ matrix.db_alias != '' && matrix.db_alias || matrix.db }}
 
         services:
             mssql:
-                image: ${{ matrix.db != 'mcr.microsoft.com/mssql/server:2022-CU13-ubuntu-22.04' && matrix.db != 'mcr.microsoft.com/mssql/server:2019-CU27-ubuntu-20.04' && 'mcr.microsoft.com/mssql/server:2022-CU13-ubuntu-22.04' || matrix.db }}
+                image: ${{ matrix.db_image }}
                 env:
                     SA_PASSWORD: "Pssw0rd_12"
                     ACCEPT_EULA: "y"
@@ -559,19 +562,6 @@ jobs:
               with:
                   path: phpBB3/phpBB/ext/${{ env.EXTNAME }}
 
-            - name: Set database type
-              id: database-type
-              env:
-                  MATRIX_DB: ${{ matrix.db }}
-              run: |
-                  if [ "$MATRIX_DB" == 'mcr.microsoft.com/mssql/server:2022-CU13-ubuntu-22.04' ] || [ "$MATRIX_DB" == 'mcr.microsoft.com/mssql/server:2019-CU27-ubuntu-20.04' ]
-                  then
-                      db='mssql'
-                  else
-                      db="${MATRIX_DB%%:*}"
-                  fi
-                  echo "db=$db" >> "$GITHUB_OUTPUT"
-
             - name: Setup PHP
               uses: shivammathur/setup-php@v2
               with:
@@ -581,7 +571,7 @@ jobs:
 
             - name: Setup environment for phpBB
               env:
-                  DB: ${{steps.database-type.outputs.db}}
+                  DB: ${{ matrix.db }}
                   PHP_VERSION: ${{ matrix.php }}
                   NOTESTS: '0'
               run: .github/setup-phpbb.sh "$DB" "$PHP_VERSION" "${NOTESTS:-0}"
@@ -589,7 +579,7 @@ jobs:
 
             - name: Setup database
               env:
-                  DB: ${{steps.database-type.outputs.db}}
+                  DB: ${{ matrix.db }}
                   MYISAM: '0'
               run: .github/setup-database.sh "$DB" "$MYISAM"
               working-directory: ./phpBB3
@@ -635,7 +625,7 @@ jobs:
 
             - name: Run unit tests
               env:
-                  DB: ${{steps.database-type.outputs.db}}
+                  DB: ${{ matrix.db }}
               run: |
                   args=()
                   if [ "$FUNCTIONAL_TESTS" == "0" ]; then